Details
-
Task
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
None
-
None
-
None
-
Reviewed
Description
As part of the SCP, after we are done splitting WALs, we try removing the -splitting dirs but if the dir doesn't exist, dfs#delete fails with IOE. Since we are aware of this case, we just log the message but we don't interrupt SCP because handling of the failure is gracefully done.
Hence, failure to remove "-splitting" dir should not be mentioned as WARN log, let's convert this to INFO level:
LOG.warn("Remove WAL directory for {} failed, ignore...{}", serverName, e.getMessage());
Any other genuine failure to remove the splitting dir is anyways covered by this log, hence we don't have worry about keeping the above mentioned log at WARN level, we have anyways mentioned "ignore..." in the log message.
if (!fs.delete(splitDir, false)) { LOG.warn("Failed delete {}, contains {}", splitDir, fs.listFiles(splitDir, true)); }
Attachments
Issue Links
- links to