Details
-
Sub-task
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
-
None
-
Reviewed
Description
LZ4 was changed in hadoop-3.3.1 to use a more amenable library, one that did not require gymnastics installing lz4 native libs everywhere; rather, you just add a jar to the classpath. See HADOOP-17292.
Similar was done for SNAPPY. See HADOOP-17125.
What this means is that our TestCompressionTest passes for hadoop before 3.3.1 but at 3.3.1, the assert that SNAPPY and LZ4 compressors should fail – because no lib installed – now no longer asserts.
While in here, LZO is GPL and requires extra install to setup [1]. When TestCompressionTest runs, it emits the below for the LZO check. The check is kinda useless.
2021-05-28T10:05:36,513 WARN [Time-limited test] util.CompressionTest(75): Can't instantiate codec: lzo
org.apache.hadoop.hbase.DoNotRetryIOException: Compression algorithm 'lzo' previously failed test.
I think best thing for now is to comment out the asserts that LZ4 and SNAPPY do NOT work when binary cannot be found – since this holds only if hadoop < 3.3..1; the test is a little weak anyways.
Attachments
Issue Links
- links to