[HBASE-25850] Fix spotbugs warnings on branch-2 - ASF JIRA

Log work

Agile Board

Rank to Top

Rank to Bottom

Attach files

Attach Screenshot

Bulk Copy Attachments

Bulk Move Attachments

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Move

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 2.5.0
Component/s: Compaction, findbugs, mob
Labels:
- beginner
- trivial

Hadoop Flags:

Reviewed

Description

Dodgy code Warnings
Code	Warning
UC	Useless condition: it's known that major == true at this point
Bug type UC_USELESS_CONDITION (click for details)
In class org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor
In method org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor.performCompaction(Compactor$FileDetails, InternalScanner, CellSink, long, boolean, ThroughputController, boolean, int)
Value major == true
Unreachable code at DefaultMobStoreCompactor.java:[line 210]
At DefaultMobStoreCompactor.java:[line 210]

https://github.com/apache/hbase/blob/afa9836b87f9c909ac4fc18d904a5b5b0a3dfff6/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java#L211

      if (major) {
        try {
          delFileWriter = mobStore.createDelFileWriterInTmp(new Date(fd.latestPutTs),
            fd.maxKeyCount, major ? majorCompactionCompression : minorCompactionCompression,
            store.getRegionInfo().getStartKey());
        } catch (IOException e) {
          LOG.warn(
            "Failed to create del writer, "
            + "we will continue the compaction by writing delete markers directly in store files",
            e);
        }
      }

The 'major ? majorCompactionCompression : minorCompactionCompression' is useless as we have a 'if (major)' test above.