[HBASE-25834] Remove balanceTable method from LoadBalancer interface - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Sub-task
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.0.0-alpha-1, 2.5.0
Component/s: Balancer
Labels:
None

Hadoop Flags:

Reviewed
Release Note:

Hide
Remove balanceTable method from LoadBalancer interface as we never call it outside balancer implementation.
Mark balanceTable method as protected in BaseLoadBalancer.
Mark balanceCluster method as final in BaseLoadBalancer, the implementation classes should not override it anymore, just implement the balanceTable method is enough.

Show
Remove balanceTable method from LoadBalancer interface as we never call it outside balancer implementation. Mark balanceTable method as protected in BaseLoadBalancer. Mark balanceCluster method as final in BaseLoadBalancer, the implementation classes should not override it anymore, just implement the balanceTable method is enough.

Description

The balanceTable method is never called outside balancer implementation, so let's remove it from the interface to reduce the number of public methods, which could also reduce the work of synchronization.

Attachments

Issue Links

links to

GitHub Pull Request #3217

Activity

People

Assignee:: Duo Zhang

Reporter:: Duo Zhang

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 02/May/21 14:14

Updated:: 06/May/21 13:40

Resolved:: 05/May/21 08:08