Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-25324

Remove unnecessary array to list conversion in SplitLogManager

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.0.0-alpha-1, 2.4.0
    • None
    • None

    Description

        public static List<FileStatus> getFileList(final Configuration conf, final List<Path> logDirs,
            final PathFilter filter)
            throws IOException {
          List<FileStatus> fileStatus = new ArrayList<>();
          ....
          FileStatus[] a = new FileStatus[fileStatus.size()];
          //list to array
          return fileStatus.toArray(a);
        }
      
        public List<FileStatus> getWALsToSplit(ServerName serverName, boolean splitMeta)
            throws IOException {
          List<Path> logDirs = master.getMasterWalManager().getLogDirs(Collections.singleton(serverName));
          FileStatus[] fileStatuses =
              SplitLogManager.getFileList(this.conf, logDirs, splitMeta ? META_FILTER : NON_META_FILTER);
          LOG.info("{} WAL count={}, meta={}", serverName, fileStatuses.length, splitMeta);
          //array convert to list which is just contrary to the logic of  getFileList
          return Lists.newArrayList(fileStatuses);
        
      

      After judge the logic, there seems no need to make such a conversion.

      Attachments

        Issue Links

          Activity

            People

              yuqi yuqi
              yuqi yuqi
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: