Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-24797

Move log code out of loop

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.0.0-alpha-1
    • 3.0.0-alpha-1, 2.3.1, 2.4.0
    • Normalizer
    • None
    • Reviewed

    Description

      In HMaster#normalizeRegions, maybe we shoule move the log code about  submittedPlanProcIds out of loop.

       

      public boolean normalizeRegions() throws IOException {
        ...
          final List<Long> submittedPlanProcIds = new ArrayList<>();
          for (TableName table : allEnabledTables) {
            ...
            for (NormalizationPlan plan : plans) {
              long procId = plan.submit(this);
              submittedPlanProcIds.add(procId);
              ...
            }
            int totalPlansSubmitted = submittedPlanProcIds.size();
            if (totalPlansSubmitted > 0 && LOG.isDebugEnabled()) {
              LOG.debug("Normalizer plans submitted. Total plans count: {} , procID list: {}",
                totalPlansSubmitted, submittedPlanProcIds);
            }
          }
        ...
      }
      

       

       

      Attachments

        Issue Links

          Activity

            People

              Ddupg Sun Xin
              Ddupg Sun Xin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: