Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-24065

Enable SpotBugs in PreCommit

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Not A Problem
    • 3.0.0-alpha-1, 2.3.0
    • None
    • build, test
    • None

    Description

      Yetus's SpotBugs module depends on maven_add_install. In Jenkinsfile_GitHub, I'm pretty strict on my module definitions, with

      GENERAL_CHECK_PLUGINS = 'all,-compile,-javac,-javadoc,-jira,-shadedjars,-unit'
JDK_SPECIFIC_PLUGINS = 'compile,github,htmlout,javac,javadoc,maven,mvninstall,shadedjars,unit'

      The general check requests all but omits compile and maven, which I think means the spotbugs check gets dropped. Before HBASE-23767, we had just a single yetus that did all, so spotbugs would have been run.

      Attachments

        Issue Links

          is caused by

          Sub-task - The sub-task of the issue HBASE-23767 Add JDK11 compilation and unit test support to Github precommit

          • Major - Major loss of function.
          • Resolved
          is duplicated by

          Task - A task that needs to be done. HBASE-22383 github PR integration for qabot needs spotbugs/findbugs

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          is related to

          Task - A task that needs to be done. HBASE-23077 move entirely to spotbugs

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link GitHub Pull Request #1364

          Activity

            People

              ndimiduk Nick Dimiduk
              ndimiduk Nick Dimiduk
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: