[HBASE-22150] rssStub in HRegionServer is not thread safe and should not directly be used - ASF JIRA

Log work

Agile Board

Rank to Top

Rank to Bottom

Attach files

Attach Screenshot

Bulk Copy Attachments

Bulk Move Attachments

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Move

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 3.0.0-alpha-1, 2.2.0
Fix Version/s: 3.0.0-alpha-1, 2.3.0
Component/s: regionserver
Labels:
None

Description

While working on a patch for ~~HBASE-22060~~, I noticed that a unit test started failing because region server crashed with NPE during initialization and after aborting the master. It turned out that access to the rssStub was not synchronized.

The existing code in HRegionServer already takes care of this fact by copying and null checking in most places, but there are a couple ones that are not so careful. Those are in reportForDuty and abort methods.