Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21899

Fix missing variables in slf4j Logger

    XMLWordPrintableJSON

Details

    Description

      I happened to find the following methods have called slf4j Logger without variables whereas {} exists.

      org.apache.hadoop.hbase.master.procedure.ReopenTableRegionsProcedure#executeFromState
      org.apache.hadoop.hbase.replication.regionserver.SerialReplicationChecker#canPush(org.apache.hadoop.hbase.wal.WAL.Entry, org.apache.hadoop.hbase.Cell)

      With my quick patch, I was able to log the condition appropriately at least for SerialReplicationChecker.

      2019-02-14 02:34:46,365 TRACE [Time-limited test] regionserver.SerialReplicationChecker(258): The sequence id for Mock for Entry, hashCode: 2138280514 is continuous, pass
      

       

      Attachments

        1. HBASE-21899.branch-2.001.patch
          2 kB
          Toshihiro Suzuki
        2. HBASE-21899.branch-2.001.patch
          2 kB
          Daisuke Kobayashi

        Activity

          People

            daisuke.kobayashi Daisuke Kobayashi
            daisuke.kobayashi Daisuke Kobayashi
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: