Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21062

WALFactory has misleading notion of "default"

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0-alpha-1, 2.2.0, 2.1.1, 2.0.2
    • wal
    • None
    • Reviewed

    Description

      In WALFactory, there is an enum Providers which has a list of supported WALProvider implementations. In addition to list this, there is also a defaultProvider (which the Configuration defaults to), that is meant to be our "advertised" default WALProvider.

      However, the implementation of getProviderClass in WALFactory doesn't actually adhere to the value of this enum, instead always returning AsyncFSWal if it can be loaded.

      Having the default value in the enum but then overriding it in the implementation of getProviderClass is silly and misleading.

      Attachments

        1. HBASE-21062.001.branch-2.0.patch
          4 kB
          Josh Elser
        2. HBASE-21062.002.branch-2.0.patch
          5 kB
          Josh Elser

        Issue Links

          Activity

            People

              elserj Josh Elser
              elserj Josh Elser
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: