Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20704

Sometimes some compacted storefiles are not archived on region close

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      During region close compacted files which have not yet been archived by the discharger are archived as part of the region closing process. It is important that these files are wholly archived to insure data consistency. ie a storefile containing delete tombstones can be archived while older storefiles containing cells that were supposed to be deleted are left unarchived thereby undeleting those cells. 

      On region close a compacted storefile is skipped from archiving if it has read references (ie open scanners). This behavior is correct for when the discharger chore runs but on region close consistency is of course more important so we should add a special case to ignore any references on the storefile and go ahead and archive it. 

      Attached patch contains a unit test that reproduces the problem and the proposed fix.

      Attachments

        1. HBASE-20704-branch-1.002.patch
          Delete this attachment
          16 kB
          Andrew Kyle Purtell
        2. HBASE-20704-addendum.patch
          Delete this attachment
          4 kB
          Andrew Kyle Purtell
        3. HBASE-20704.branch-1.001.patch
          Delete this attachment
          14 kB
          Francis Christopher Liu
        4. HBASE-20704.007.patch
          Delete this attachment
          19 kB
          Francis Christopher Liu
        5. HBASE-20704.006.patch
          Delete this attachment
          19 kB
          Francis Christopher Liu
        6. HBASE-20704.005.patch
          Delete this attachment
          18 kB
          Francis Christopher Liu
        7. HBASE-20704.004.draft.patch
          Delete this attachment
          18 kB
          Francis Christopher Liu
        8. HBASE-20704.003.patch
          Delete this attachment
          13 kB
          Francis Christopher Liu
        9. HBASE-20704.002.patch
          Delete this attachment
          10 kB
          Francis Christopher Liu
        10. HBASE-20704.001.patch
          Delete this attachment
          10 kB
          Francis Christopher Liu

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            toffer Francis Christopher Liu Assign to me
            toffer Francis Christopher Liu
            Votes:
            0 Vote for this issue
            Watchers:
            17 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment