Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20441

Use checkstyle to ban imports from commons-lang 2

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      We updated to commons-lang 3 in HBASE-18674 but we've regressed:

      $ git grep org.apache.commons.lang\\.
hbase-common/src/main/java/org/apache/hadoop/hbase/net/Address.java:import org.apache.commons.lang.StringUtils;
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/FileArchiverNotifierFactoryImpl.java:import org.apache.commons.lang.builder.HashCodeBuilder;
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/FileArchiverNotifierImpl.java:import org.apache.commons.lang.builder.HashCodeBuilder;
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHdfsSnapshotHRegion.java:import org.apache.commons.lang.StringUtils;
hbase-server/src/test/java/org/apache/hadoop/hbase/util/compaction/TestMajorCompactionRequest.java:import org.apache.commons.lang.RandomStringUtils;

      we should add the same kind of check as we do for e.g. hadoop annotations.

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            meszibalu Balazs Meszaros Assign to me
            busbey Sean Busbey
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment