Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-19922

ProtobufUtils::PRIMITIVES is unused

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0-beta-2, 2.0.0
    • Protobufs
    • None

    Description

      It looks like ProtobufUtils::PRIMITIVES is never read in both the shaded and non-shaded versions of the class. Is it safe to remove?

      https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java#L128

      We populate the map in a static initializer but never read any values from it...

      Attachments

        1. HBASE-19922.patch
          3 kB
          Mike Drob
        2. HBASE-19922.v2.patch
          4 kB
          Mike Drob

        Activity

          People

            mdrob Mike Drob
            mdrob Mike Drob
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: