Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18587

Fix Flaky TestFileIOEngine

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.4.0, 1.3.2, 2.0.0
    • BucketCache, test
    • None
    • Reviewed

    Description

      As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine failed. I investigated and noticed that there are two cases where this test is flaky:
      len = 0 and offset 0; it will fail for https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198 will pass in -1 for offset which is invalid.
      len = 0 and i = 13; it will try to specify an offset of the totalCapacity which is not allowed.

      This patch fixes this test.

      Attachments

        1. HBASE-18587.branch-1.001.patch
          8 kB
          Zach York
        2. HBASE-18587.master.001.patch
          10 kB
          Zach York
        3. HBASE-18587.master.001.patch
          10 kB
          Michael Stack
        4. HBASE-18587.master.002.patch
          10 kB
          Zach York
        5. HBASE-18587.branch-1.002.patch
          8 kB
          Zach York
        6. HBASE-18587.master.002.patch
          10 kB
          Michael Stack

        Activity

          People

            zyork Zach York
            zyork Zach York
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: