Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16929

Move default method of shipped to Shipper interface

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Won't Fix
    • 2.0.0
    • 2.0.0
    • None
    • None

    Description

      HBASE-16626 added default method of shipped() to RegionScanner.

      However, when building master branch of Phoenix against 2.0 SNAPSHOT, I got:

      [ERROR] /a/phoenix/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionScanner.java:[27,8] org.apache.phoenix.coprocessor.DelegateRegionScanner is not abstract and does not override  abstract method shipped() in org.apache.hadoop.hbase.regionserver.Shipper
[ERROR] /a/phoenix/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:[344,36] <anonymous org.apache.phoenix.coprocessor.BaseScannerRegionObserver$1> is not         abstract and does not override abstract method shipped() in org.apache.hadoop.hbase.regionserver.Shipper

      Here is the snippet for DelegateRegionScanner:

      public class DelegateRegionScanner implements RegionScanner {

      It seems adding default method in RegionScanner is not enough for downstream projects.

      After moving the default method to Shipper interface, the above two compilation errors are gone in Phoenix.

      Attachments

        1. 16929.v1.txt
          1 kB
          Ted Yu

        Issue Links

          supercedes

          Sub-task - The sub-task of the issue HBASE-16626 User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part

          • Major - Major loss of function.
          • Closed

          Activity

            People

              Unassigned Unassigned
              yuzhihong@gmail.com Ted Yu
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: