Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15148

Resolve IS2_INCONSISTENT_SYNC findbugs warning in AuthenticationTokenSecretManager

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.2.0, 1.3.0, 0.98.18, 2.0.0
    • None
    • None
    • Reviewed

    Description

      After efforts in HBASE-15118, we still see IS2_INCONSISTENT_SYNC warning in AuthenticationTokenSecretManager in HadoopQA report for HBASE-13960:

      In class org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager
      Field org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.lastKeyUpdate
      Synchronized 50% of the time
      Unsynchronized access at AuthenticationTokenSecretManager.java:[line 343]
      Synchronized access at AuthenticationTokenSecretManager.java:[line 278]
      

      Checking the code, we could see synchronized (this) in line 343 is synchronizing on the instance of the subclass AuthenticationTokenSecretManager$LeaderElector while lastKeyUpdate is a variable of the parent class instance

      Will fix the issue in this JIRA

      Attachments

        1. HBASE-15148.patch
          1 kB
          Yu Li
        2. HBASE-15148.patch
          1 kB
          Yu Li

        Issue Links

          Activity

            People

              liyu Yu Li
              liyu Yu Li
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: