Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15101

Leaked References to StoreFile.Reader after HBASE-13082

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.0
    • Component/s: HFile, io
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We observed this production that after a region server dies there are huge number of hfiles in that region for the region server running the version with HBASE-13082, In the doc it is given that it is expected to happen, but we found a one place where scanners are not being closed. If the scanners are not closed their references are not decremented and that is leading to the issue of huge number of store files not being finalized

      All I was able to find is in the selectScannersFrom, where we discard some of the scanners and we are not closing them. I am attaching a patch for that.

      Also to avoid these issues should the files that are done be logged and finalized (moved to archive) as a part of region close operation. This will solve any leaks that can happen and does not cause any dire consequences?

        Attachments

        1. HBASE-15101-v4.patch
          2 kB
          deepankar
        2. HBASE-15101-v3.patch
          1.0 kB
          deepankar
        3. HBASE-15101-v2.patch
          1 kB
          deepankar
        4. HBASE-15101-v1.patch
          2 kB
          deepankar
        5. HBASE-15101.patch
          5 kB
          deepankar

          Activity

            People

            • Assignee:
              dvdreddy deepankar
              Reporter:
              dvdreddy deepankar
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: