Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9779

create constant RpcConstants.CLIENT_ID_LENGTH rather than hard-coding 16 everywhere

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Duplicate
    • None
    • None
    • None
    • None

    Description

      We should create a constant RpcConstants.CLIENT_ID_LENGTH rather than hard-coding the number 16 everywhere.

      Sun Java coding style convention 10.3:

      Numerical constants (literals) should not be coded directly, except for -1, 0, and 1, which can appear in a for loop as counter values.

      Attachments

        1. HADOOP-9779.1.patch
          3 kB
          Tsuyoshi Ozawa
        2. HADOOP-9779.2.patch
          4 kB
          Tsuyoshi Ozawa

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. HADOOP-9822 create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. HADOOP-9821 ClientId should have getMsb/getLsb methods

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              ozawa Tsuyoshi Ozawa
              cmccabe Colin McCabe
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: