Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-18905

Negative timeout in ZKFailovercontroller due to overflow

    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      Graceful fence timeout of FailoverController in ZKFailovercontroller equals to `ha.failover-controller.graceful-fence.rpc-timeout.ms` * 2. Since users are unaware of this calculation, it thus has risks of overflowing to a negative number if users set `ha.failover-controller.graceful-fence.rpc-timeout.ms` to a large value.
       
      To reproduce:
      1. set `ha.failover-controller.graceful-fence.rpc-timeout.ms` to 1092752431
      2. run `mvn surefire:test -Dtest=org.apache.hadoop.ha.TestZKFailoverController#testGracefulFailoverFailBecomingStandby`
       
      We create a PR that provides a fix by checking the timeout after multiplication is at least 0.
       

      Attachments

        Issue Links

          Activity

            People

              FuzzingTeam ConfX
              FuzzingTeam ConfX
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: