[HADOOP-18675] CachedSASToken noisy log errors when SAS token has YYYY-MM-DD expiration - ASF JIRA

Add vote

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Open
Priority: Major
Resolution: Unresolved
Affects Version/s: None
Fix Version/s: None
Component/s: fs/azure
Labels:
- pull-request-available

Description

Error Description:

When using SAS tokens with expiration dates in the format YYYY-MM-DD, a frequent error appears in the logs related to the date format. The error expects an ISO_DATE_TIME. See existing implementation. The error is noisy in the logs, but does not cause issues.

Example stacktrace:

23/03/23 15:40:06 ERROR CachedSASToken: Error parsing se query parameter (2023-11-05) from SAS.
java.time.format.DateTimeParseException: Text '2023-11-05' could not be parsed at index 10
	at java.time.format.DateTimeFormatter.parseResolved0(DateTimeFormatter.java:1949)
	at java.time.format.DateTimeFormatter.parse(DateTimeFormatter.java:1851)
	at java.time.OffsetDateTime.parse(OffsetDateTime.java:402)
	at shaded.databricks.azurebfs.org.apache.hadoop.fs.azurebfs.utils.CachedSASToken.getExpiry(CachedSASToken.java:116)
	at shaded.databricks.azurebfs.org.apache.hadoop.fs.azurebfs.utils.CachedSASToken.update(CachedSASToken.java:168)
	at shaded.databricks.azurebfs.org.apache.hadoop.fs.azurebfs.services.AbfsInputStream.readRemote(AbfsInputStream.java:670)
	at shaded.databricks.azurebfs.org.apache.hadoop.fs.azurebfs.services.ReadBufferWorker.lambda$run$0(ReadBufferWorker.java:66)
	at com.databricks.common.SparkTaskIOMetrics.withTaskIOMetrics(SparkTaskIOMetrics.scala:43)
	at shaded.databricks.azurebfs.org.apache.hadoop.fs.azurebfs.services.ReadBufferWorker.run(ReadBufferWorker.java:65)
	at java.lang.Thread.run(Thread.java:750)

Desired Resolution:

Expiration code can read YYYY-MM-DD format as well as existing format.