Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-15960 Update guava to 27.0-jre in hadoop-project
  3. HADOOP-16218

findbugs warning of null param to non-nullable method in Configuration with Guava update

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.3.0
    • 3.3.0
    • build
    • None

    Description

      Findbugs is fussing over some unchanged code in configuration

      Null passed for non-null parameter of writeXml(String, Writer) in org.apache.hadoop.conf.Configuration.writeXml(Writer)
Bug type NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS (click for details) 
In class org.apache.hadoop.conf.Configuration
In method org.apache.hadoop.conf.Configuration.writeXml(Writer)
Called method org.apache.hadoop.conf.Configuration.writeXml(String, Writer)
At Configuration.java:[line 3490]
Argument 1 is definitely null but must not be null
Definite null passed to dangerous method call target org.apache.hadoop.conf.Configuration.writeXml(String, Writer)

      Code looks fine; it's invoking Guava.Strings for the check for string == empty-or-null; maybe something changed there.

      Proposed: add @Nullable in Configuration writeXml

      Attachments

        Issue Links

          is required by

          Sub-task - The sub-task of the issue HADOOP-16210 Update guava to 27.0-jre in hadoop-project trunk

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          links to

          Web Link GitHub Pull Request #655

          Activity

            People

              stevel@apache.org Steve Loughran
              stevel@apache.org Steve Loughran
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: