Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-16126

ipc.Client.stop() may sleep too long to wait for all connections

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.10.0, 3.3.0, 2.8.6, 2.9.3, 3.1.4, 3.2.2
    • ipc
    • None

    Description

      //Client.java
        public void stop() {
          ...
          // wait until all connections are closed
          while (!connections.isEmpty()) {
            try {
              Thread.sleep(100);
            } catch (InterruptedException e) {
            }
          }
          ...
        }
      

      In the code above, the sleep time is 100ms. We found that simply changing the sleep time to 10ms could improve a Hive job running time by 10x.

      Attachments

        1. c16126_20190221.patch
          1.0 kB
          Tsz-wo Sze
        2. c16126_20190220.patch
          1.0 kB
          Tsz-wo Sze
        3. c16126_20190219.patch
          0.6 kB
          Tsz-wo Sze

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            szetszwo Tsz-wo Sze
            szetszwo Tsz-wo Sze
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment