VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • HADOOP-15407
    • 3.2.0
    • fs/azure
    • None

    Description

      Followup on HADOOP-15540 with some initial review tuning

      Tuning

      • ordering of imports
      • rely on azure-auth-keys.xml to store credentials (change imports, docs,.gitignore)
      • log4j -> info
      • add a "." to the first sentence of all the javadocs I noticed.
      • remove @Public annotations except for some constants (which includes some commitment to maintain them).
      • move the AbstractFS declarations out of the src/test/resources XML file into core-default.xml for all to use
      • other IDE-suggested tweaks

      Testing

      Review the tests, move to ContractTestUtil assertions, make more consistent to contract test setup, and general work to make the tests work well over slower links, document, etc.

      Attachments

        1. HADOOP-15546-HADOOP-15407-012.patch
          284 kB
          Da Zhou
        2. HADOOP-15546-HADOOP-15407-011.patch
          276 kB
          Steve Loughran
        3. HADOOP-15546-HADOOP-15407-010.patch
          269 kB
          Da Zhou
        4. HADOOP-15546-HADOOP-15407-009.patch
          276 kB
          Steve Loughran
        5. azure-auth-keys.xml
          3 kB
          Sean Mackrory
        6. HADOOP-15546-HADOOP-15407-008.patch
          276 kB
          Steve Loughran
        7. HADOOP-15546-HADOOP-15407-007.patch
          263 kB
          Steve Loughran
        8. HADOOP-15546-HADOOP-15407-006.patch
          254 kB
          Steve Loughran
        9. HADOOP-15546-HADOOP-15407-006.patch
          254 kB
          Steve Loughran
        10. HADOOP-15546-HADOOP-15407-005.patch
          253 kB
          Steve Loughran
        11. HADOOP-15546-HADOOP-15407-004.patch
          110 kB
          Steve Loughran
        12. HADOOP-15546-HADOOP-15407-003.patch
          110 kB
          Steve Loughran
        13. HADOOP-15546-HADOOP-15407-002.patch
          102 kB
          Steve Loughran
        14. HADOOP-15546-HADOOP-15407-001.patch
          54 kB
          Steve Loughran
        15. HADOOP-15546-001.patch
          54 kB
          Steve Loughran

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tmarquardt Thomas Marqardt
            stevel@apache.org Steve Loughran
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment