Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13721

Remove stale method ViewFileSystem#getTrashCanLocation

VotersStop watchingWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.0.0-alpha2
    • 3.0.0-alpha2
    • viewfs
    • None
    • Incompatible change
    • The unused method getTrashCanLocation has been removed. This method has long been superceded by FileSystem#getTrashRoot.

    Description

      ViewFileSystem which extends FileSystem has a public method getTrashCanLocation which is neither overridden nor used by anybody. Looks like it existed when the file was created, and also I see the implementation returning homeDirectory which might not be the expected one in cases of expunge. So, inclined to remove this stale and potentially dangerous method unless anyone has any concerns.

        public Path getTrashCanLocation(final Path f) throws FileNotFoundException {
          final InodeTree.ResolveResult<FileSystem> res = 
            fsState.resolve(getUriPath(f), true);
          return res.isInternalDir() ? null : res.targetFileSystem.getHomeDirectory();
        }
      

      Attachments

        1. HADOOP-13721.01.patch
          1.0 kB
          Manoj Govindassamy

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            manojg Manoj Govindassamy
            manojg Manoj Govindassamy
            Votes:
            0 Vote for this issue
            Watchers:
            5 Stop watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment