Uploaded image for project: 'Guacamole'
  1. Guacamole
  2. GUACAMOLE-1757

Add SSO providers list to UI at most once

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Done
    • None
    • 1.6.0
    • guacamole
    • None

    Description

      Each of the current SSO extensions work by leveraging HTML patches to add an SSO providers list to the login UI, which each subsequent SSO extension adds to. Since this results in multiple copies of the list, CSS is used to hide all but the last of these, as only the last such list will have all expected entries.

      This works, but the CSS involved relies on :last-child and will not behave as expected if anything else is added to the same area of the login UI. It would be far better if the SSO providers list were always added exactly once, regardless of how many SSO extensions are installed.

      Attachments

        Activity

          People

            mjumper Mike Jumper
            mjumper Mike Jumper
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: