Uploaded image for project: 'Guacamole'
  1. Guacamole
  2. GUACAMOLE-1714

Update guacenc for FFmpeg 5.0 API

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.5.5
    • guacenc
    • None

    Description

      Recent versions of FFmpeg have switched to const arguments and return values for several functions, resulting in the following build failure:

      ...
        CC       guacenc-video.o
      video.c: In function 'guacenc_video_alloc':
      video.c:63:22: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
         63 |     container_format = container_format_context->oformat;
            |                      ^
      video.c:66:22: error: initialization discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
         66 |     AVCodec* codec = avcodec_find_encoder_by_name(codec_name);
            |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cc1: all warnings being treated as errors
      make[2]: *** [Makefile:1126: guacenc-video.o] Error 1
      

      As suggested by guacamole-server PR #379, const should be added as necessary to satisfy the build.

      Attachments

        Issue Links

          Activity

            People

              vnick Nick Couchman
              mjumper Mike Jumper
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: