Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-34588

FineGrainedSlotManager checks whether resources need to reconcile but doesn't act on the result

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 1.19.0, 1.18.1, 1.20.0
    • None
    • Runtime / Coordination
    • None

    Description

      There are a few locations in FineGrainedSlotManager where we check whether resources can/need to be reconciled but don't care about the result and just trigger the resource update (e.g. in FineGrainedSlotManager:626 and FineGrainedSlotManager:682). Looks like we could reduce the calls to the backend here.

      It's not having a major impact because this feature is only used in the ActiveResourceManager which triggers checkResourceDeclarations and reevaluates the resourceDeclarations. Not sure whether I missed something here and there's actually a bigger issue with it. But considering that nobody complained about it in the past, I'd assume that it's not a severe issue.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              mapohl Matthias Pohl
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated: