[FLINK-31911] Bad address construction in SqlClientTest - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Sub-task
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.16.0
Fix Version/s: 1.18.0
Component/s: Table SQL / Client, Tests
Labels:
- pull-request-available

Description

The SqlClientTest constructs a host:port pair with this:

InetSocketAddress.createUnresolved(
                                    SQL_GATEWAY_REST_ENDPOINT_EXTENSION.getTargetAddress(),
                                    SQL_GATEWAY_REST_ENDPOINT_EXTENSION.getTargetPort())
                            .toString()

This is unnecessarily complicated and fails on Java 17 because the toString representation is not guaranteed to return something of the form host:port.

Attachments

Issue Links

links to

GitHub Pull Request #22473

Activity

People

Assignee:: Chesnay Schepler

Reporter:: Chesnay Schepler

Votes:: 0 Vote for this issue

Watchers:: 0 Start watching this issue

Dates

Created:: 24/Apr/23 08:14

Updated:: 27/Apr/23 12:17

Resolved:: 27/Apr/23 12:17