Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Not A Problem
-
None
-
None
-
None
Description
Redundant NotNull checks in function cli/CliFrontend.
getEffectiveConfiguration():
final ExecutionConfigAccessor executionParameters =
ExecutionConfigAccessor.fromProgramOptions(
checkNotNull(programOptions), checkNotNull(jobJars));
while ExecutionConfigAccessor.fromProgramOptions indeed does the notNull check
public static <T> ExecutionConfigAccessor fromProgramOptions( final ProgramOptions options, final List<T> jobJars) { checkNotNull(options); checkNotNull(jobJars); ... }
I have searched other ExecutionConfigAccessor.fromProgramOptions() usages, and all of them do not use checkNotNull in invokion