Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-25325

Migration Flink from Junit4 to Junit5

    XMLWordPrintableJSON

Details

    • New Feature
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 1.14.0
    • 1.20.0
    • Tests

    Description

      Based on the consensus from the mailing list discussion[1][2], we have been starting working on the JUnit4 to JUnit5 migration. 

      This is the umbrella ticket which describes the big picture of the migration with following steps:

      • AssertJ integration and guideline
      • Test Framework upgrade from JUnit4 to JUnit5
      • JUnit5 migration guideline(document and reference migration)
      • Optimization for issues found while writing new test in JUint5
      • [Long-term]Module based graceful migration of old tests in JUnit4 to JUnit5

      All JUnit5 migration related tasks are welcome to be created under this umbrella. 

       

      https://github.com/apache/flink/pull/24483 is an excellent PR as example. Please create similar Brief change log summary for new PR.

       

      [1] [DISCUSS]Moving to JUnit5

      [2] [DISCUSS] Conventions on assertions to use in tests

      [3] JUnit5 migration guide

      Attachments

        Issue Links

          duplicates

          New Feature - A new feature of the product, which has yet to be developed. FLINK-23254 Upgrade Test Framework to JUnit 5

          • Major - Major loss of function.
          • Closed
          is a parent of

          New Feature - A new feature of the product, which has yet to be developed. FLINK-23254 Upgrade Test Framework to JUnit 5

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. FLINK-25858 Remove ArchUnit rules for JUnit 4 in ITCaseRules after the JUnit 4->5 migration is closed

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. FLINK-24627 Port JUnit 4 rules to JUnit5 extensions

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. FLINK-26218 Enable JUnit 5 Automatic Extension Detection

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. FLINK-32055 Migrate all subclasses of BatchAbstractTestBase to JUnit5

          • Major - Major loss of function.
          • Closed

          Technical Debt - FLINK-29541 [JUnit5 Migration] Module: flink-table-planner

          • Major - Major loss of function.
          • Resolved

          Technical Debt - FLINK-25315 Add new extensions and classes to help the JUnit5 migration

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Technical Debt - FLINK-25061 Add assertj as dependency in flink-parent

          • Major - Major loss of function.
          • Closed
          1.
          		 [JUnit5 Migration] Module: flink-core Sub-task Reopened Aiden Gong
          2.
          		 [JUnit5 Migration] Module: flink-connector-kafka Sub-task Open xiang1 yu
          3.
          		 [JUnit5 Migration] Module: flink-runtime Sub-task Closed Unassigned
          4.
          		 [JUnit5 Migration] Module: flink-test-utils Sub-task Closed Chesnay Schepler
          5.
          		 [JUnit5 Migration] Module: flink-runtime-web Sub-task Closed Unassigned
          6.
          		 [JUnit5 Migration] Module: flink-yarn Sub-task Closed RocMarshal
          7.
          		 [JUnit5 Migration] Module: flink-streaming-java Sub-task Resolved Jiabao Sun
          8.
          		 [JUnit5 Migration] Module: flink-clients Sub-task Closed RocMarshal
          9.
          		 [JUnit5 Migration] Module: flink-connector-base Sub-task Open Sergey Nuyanzin
          10.
          		 [JUnit5 Migration] Module: flink-optimizer Sub-task Closed Unassigned
          11.
          		 [JUnit5 Migration] Module: flink-sql-parser Sub-task Closed Sergey Nuyanzin
          12.
          		 [JUnit5 Migration] Module: flink-dstl Sub-task Closed RocMarshal
          13.
          		 [JUnit5 Migration] Module: flink-kuberbetes Sub-task Closed reswqa
          14.
          		 [JUnit5 Migration] Module: flink-metrics-statsd Sub-task Closed Chesnay Schepler
          15.
          		 [JUnit5 Migration] Module: flink-metrics-slf4j Sub-task Closed Chesnay Schepler
          16.
          		 [JUnit5 Migration] Module: flink-metrics-prometheus Sub-task Closed Chesnay Schepler
          17.
          		 [JUnit5 Migration] Module: flink-metrics-jmx Sub-task Closed Chesnay Schepler
          18.
          		 [JUnit5 Migration] Module: flink-metrics-influxdb Sub-task Closed Chesnay Schepler
          19.
          		 [JUnit5 Migration] Module: flink-metrics-graphite Sub-task Closed Chesnay Schepler
          20.
          		 [JUnit5 Migration] Module: flink-metrics-dropwizard Sub-task Closed Chesnay Schepler
          21.
          		 [JUnit5 Migration] Module: flink-metrics-datadog Sub-task Closed Chesnay Schepler
          22.
          		 [JUnit5 Migration] Module: flink-metrics-core Sub-task Closed Chesnay Schepler
          23.
          		 [JUnit5 Migration] Module: flink-avro Sub-task Closed Ryan Skraba
          24.
          		 [JUnit5 Migration] Module: flink-runtime-web Sub-task Closed Chesnay Schepler
          25.
          		 [JUnit5 Migration] Module: flink-rpc-core Sub-task Closed Chesnay Schepler
          26.
          		 [JUnit5 Migration] Module: flink-rpc-akka Sub-task Closed Chesnay Schepler
          27.
          		 [JUnit5 Migration] Module: flink-rpc-akka-loader Sub-task Closed Chesnay Schepler
          28.
          		 [JUnit5 Migration] Module: flink-yarn-test Sub-task Closed RocMarshal
          29.
          		 [JUnit5 Migration] Module: flink-avro-confluent-registry Sub-task Closed Ryan Skraba
          30.
          		 [JUnit5 Migration] Module: flink-external-resources Sub-task Closed RocMarshal
          31.
          		 [JUnit5 Migration] Module: flink-container Sub-task Closed RocMarshal
          32.
          		 [JUnit5 Migration] Module: flink-*-glue-schema-registry Sub-task Closed Ryan Skraba
          33.
          		 [JUnit5 Migration] Module: flink-compress Sub-task Closed Ryan Skraba
          34.
          		 [JUnit5 Migration] Module: flink-docs Sub-task Closed RocMarshal
          35.
          		 [JUnit5 Migration] Module: flink-filesystems Sub-task Open Jörn Kottmann
          36.
          		 [JUnit5 Migration] Module: flink-contrib Sub-task Closed RocMarshal
          37.
          		 [JUnit5 Migration] Module: java-ci-tools Sub-task Closed Chesnay Schepler
          38.
          		 [JUnit5 Migration] Module: flink-table-api-java Sub-task Closed Sergey Nuyanzin
          39.
          		 [JUnit5 Migration] Module: flink-python Sub-task Closed Sergey Nuyanzin
          40.
          		 [JUnit5 Migration] Module: flink-json Sub-task Closed EMing Zhou
          41.
          		 [JUnit5 Migration] SnapshotMigrationTestBase Sub-task Open Chesnay Schepler
          42.
          		 [JUnit5 Migration] Module: flink-statebackend-heap-spillable Sub-task Closed Chesnay Schepler
          43.
          		 [JUnit5 Migration] Module: flink-table-code-splitter Sub-task Closed Sergey Nuyanzin
          44.
          		 [JUnit5 Migration] SerializerTestBase Sub-task Closed Chesnay Schepler
          45.
          		 [JUnit5 Migration] Module: flink-connector-aws-base Sub-task Closed Sergey Nuyanzin
          46.
          		 [JUnit5 Migration] Module: flink-connector-aws-kinesis-firehose Sub-task Closed Sergey Nuyanzin
          47.
          		 [JUnit5 Migration] Module: flink-connector-aws-kinesis-streams Sub-task Closed Sergey Nuyanzin
          48.
          		 [JUnit5 Migration] Module: flink-connector-files Sub-task Closed Sergey Nuyanzin
          49.
          		 [JUnit5 Migration] Migrate TypeInformationTestBase to Junit5 Sub-task Closed Sergey Nuyanzin
          50.
          		 [JUnit5 Migration] Module: flink-file-sink-common Sub-task Closed Sergey Nuyanzin
          51.
          		 [JUnit5 Migration] Module: flink-table-common Sub-task Closed Sergey Nuyanzin
          52.
          		 [JUnit5 Migration] Module: flink-table-api-scala Sub-task Closed Sergey Nuyanzin
          53.
          		 [JUnit5 Migration] Migrate ComparatorTestBase to Junit5 Sub-task Closed Sergey Nuyanzin
          54.
          		 [JUnit5 Migration] Module: flink-table-api-java-bridge Sub-task Closed Sergey Nuyanzin
          55.
          		 [JUnit5 Migration] Migrate TypeSerializerUpgradeTestBase to Junit5 Sub-task Resolved Sergey Nuyanzin
          56.
          		 [JUnit5 Migration] Module: flink-examples-table Sub-task Closed Sergey Nuyanzin
          57.
          		 [JUnit5 Migration] Module: flink-test-utils-junit Sub-task Closed Sergey Nuyanzin
          58.
          		 [JUnit5 Migration] Module: flink-table-runtime Sub-task Open Sergey Nuyanzin
          59.
          		 [JUnit5 Migration] Module: flink-scala Sub-task Closed Sergey Nuyanzin
          60.
          		 [JUnit5 Migration] Module: flink-csv Sub-task Open Ryan Skraba
          61.
          		 [JUnit5 Migration] Module: flink-connector-cassandra Sub-task Resolved Sergey Nuyanzin
          62.
          		 [JUnit5 Migration] Module: flink-connector-gcp-pubsub Sub-task Resolved Sergey Nuyanzin
          63.
          		 [JUnit5 Migration] Module: flink-connector-hbase-base Sub-task Resolved Sergey Nuyanzin
          64.
          		 [JUnit5 Migration] Module: flink-connector-hive Sub-task In Progress hk__lrzy
          65.
          		 [JUnit5 Migration] Module: flink-connector-jdbc Sub-task Closed João Boto
          66.
          		 [JUnit5 Migration] Module: flink-connector-kinesis Sub-task In Progress Ahmed Hamdy
          67.
          		 [JUnit5 Migration] Module: flink-connector-rabbitmq Sub-task Resolved Sergey Nuyanzin
          68.
          		 [JUnit5 Migration] Module: flink-hadoop-buik Sub-task Open Ryan Skraba
          69.
          		 [JUnit5 Migration] Module: flink-orc and flink-orc-nohive Sub-task Resolved Ryan Skraba
          70.
          		 [JUnit5 Migration] Migrate ScalaAPICompletenessTestBase to Junit5 Sub-task Resolved Sergey Nuyanzin
          71.
          		 JUnit5 Migration] Module: flink-sql-client Sub-task Closed zhouli
          72.
          		 [JUnit5 Migration] Module: flink-parquet Sub-task Resolved Ryan Skraba
          73.
          		 [JUnit5 Migration] Module: flink-sequence-file Sub-task Resolved Ryan Skraba
          74.
          		 [JUnit5 Migration] FileSystemBehaviorTestSuite Sub-task Resolved Ryan Skraba
          75.
          		 [JUnit5 Migration] Module: flink-java Sub-task Closed RocMarshal
          76.
          		 [JUnit5 Migration] Module: flink-hadoop-compatibility Sub-task Resolved RocMarshal
          77.
          		 [JUnit 5 Migration] Remove RetryRule Sub-task Open Unassigned
          78.
          		 [JUnit5 Migration] Module: flink-statebackend-rocksdb Sub-task Open Yangyang ZHANG
          79.
          		 [JUnit5 Migration] Module: flink-statebackend-changelog Sub-task Open Rui Xia
          80.
          		 [JUnit5 Migration] Module: flink-dstl Sub-task Closed Hangxiang Yu
          81.
          		 [JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5 Sub-task Resolved Rui Fan
          82.
          		 [JUnit5 Migration] Migrate flink-statebackend-common Sub-task Resolved Sergey Nuyanzin
          83.
          		 Harden modifiers for sql-gateway module Sub-task Resolved Sergey Nuyanzin
          84.
          		 [JUnit5 Migration] Module: flink-queryable-state Sub-task Resolved Yanfei Lei
          85.
          		 [JUnit5 Migration] The accumulators, blob and blocklist packages of flink-runtime module Sub-task Resolved Ferenc Csaky
          86.
          		 [JUnit5 Migration] The checkpoint package of flink-runtime module Sub-task Resolved Rui Fan
          87.
          		 [JUnit5 Migration] The client, clusterframework and concurrent packages of flink-runtime module Sub-task Resolved Rui Fan
          88.
          		 [JUnit5 Migration] The deployment and dispatcher packages of flink-runtime module Sub-task In Progress Rui Fan
          89.
          		 [JUnit5 Migration] The entrypoint, event, execution and externalresource packages of flink-runtime module Sub-task In Progress Rui Fan
          90.
          		 [JUnit5 Migration] The executiongraph package of flink-runtime module Sub-task Resolved Matt Wang
          91.
          		 [JUnit5 Migration] The failure, filecache, hadoop, heartbeat, highavailability and instance packages of flink-runtime module Sub-task In Progress Rui Fan
          92.
          		 [JUnit5 Migration] The iterative, jobgraph and jobmanager packages of flink-runtime module Sub-task In Progress Rui Fan
          93.
          		 [JUnit5 Migration] The jobmaster package of flink-runtime module Sub-task Open RocMarshal
          94.
          		 [JUnit5 Migration] The leaderelection, leaderretrieval, mailbox, memory and messages packages of flink-runtime module Sub-task Resolved Rui Fan
          95.
          		 [JUnit5 Migration] The metrics, minicluster and net packages of flink-runtime module Sub-task Resolved Matt Wang
          96.
          		 [JUnit5 Migration] The operators package of flink-runtime module Sub-task Resolved jiabao.sun
          97.
          		 [JUnit5 Migration] The persistence, query, registration, rpc and shuffle packages of flink-runtime module Sub-task Closed Zhanghao Chen
          98.
          		 [JUnit5 Migration] The resourcemanager package of flink-runtime module Sub-task Resolved RocMarshal
          99.
          		 [JUnit5 Migration] The io package of flink-runtime module Sub-task Resolved jiabao.sun
          100.
          		 [JUnit5 Migration] The rest package of flink-runtime module Sub-task Resolved Matt Wang
          101.
          		 [JUnit5 Migration] The scheduler package of flink-runtime module Sub-task Open RocMarshal
          102.
          		 [JUnit5 Migration] The security, taskmanager and source packages of flink-runtime module Sub-task Open Yangyang ZHANG
          103.
          		 [JUnit5 Migration] The state package of flink-runtime module Sub-task Resolved jiabao.sun
          104.
          		 [JUnit5 Migration] The taskexecutor package of flink-runtime module Sub-task Resolved jiabao.sun
          105.
          		 [JUnit5 Migration] The testtasks, testutils, throughput and throwable packages of flink-runtime module Sub-task Resolved Rui Fan
          106.
          		 [JUnit5 Migration] The webmonitor and zookeeper packages of flink-runtime module Sub-task Resolved Rui Fan
          107.
          		 [JUnit5 Migration] The util package of flink-runtime module Sub-task Resolved Zhanghao Chen
          108.
          		 Unify the TestLoggerExtension config of junit5 Sub-task In Progress Rui Fan
          109.
          		 Minimize visibility of parameterized tests Sub-task Open jiabao.sun
          110.
          		 [JUnit5 Migration] Module: flink-table-planner Sub-task Resolved Unassigned
          111.
          		 Introduce ArchTest rules to ban Junit 4 for modules already completed the migration Sub-task Resolved jiabao.sun
          112.
          		 [JUnit5 Migration] Module: flink-dist Sub-task Resolved Unassigned
          113.
          		 [JUnit5 Migration] Module: Flink CDC Sub-task Open LvYanquan

          Activity

            People

              Unassigned Unassigned
              jingge Jing Ge
              Votes:
              0 Vote for this issue
              Watchers:
              18 Start watching this issue

              Dates

                Created:
                Updated: