Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-15626 Remove legacy scheduler
  3. FLINK-16180

Replacing vertexExecution in ScheduledUnit with executionVertexID

    XMLWordPrintableJSON

Details

    Description

      ScheduledUnit#vertexExecution is nullable but ProgrammedSlotProvider requires it to be non-null to work. This makes ProgrammedSlotProvider not able to be used by new scheduler tests since vertexExecution is never set in the new scheduler code path. It blocks us from reworking tests which are based legacy scheduling to base on the new scheduler.

      Besides that, there are 2 other problems caused by the nullable vertexExecution:
      1. The log printed in SchedulerImpl#allocateSlotInternal(...) may contain no useful info since the vertexExecution can be null.
      2. NPE issue reported in FLINK-16145.

      Thus I would propose to replace the nullable vertexExecution with a non-null executionVertexID.

      Attachments

        Issue Links

          Activity

            People

              zhuzh Zhu Zhu
              zhuzh Zhu Zhu
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m