Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-1194

ShellRemote should listen on all IPs by default

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Won't Fix
    • shell.remote-1.0.4
    • None
    • Remote Shell
    • None

    Description

      shell.remote opens a server socket listening only on IP 127.0.0.1 by default (if non specified in osgi.shell.telnet.ip).
      This prevents to telnet to the console on any other IP.
      The servers socket should listen on ALL ips by default and only restrict to a single IP if osgi.shell.telnet.ip is set.
      Proposed fix:
      In org.apache.felix.shell.remote.Listener, modify:
      m_ip = getProperty(context, "osgi.shell.telnet.ip", "127.0.0.1");
      for
      m_ip = getProperty(context, "osgi.shell.telnet.ip", null);
      and in Listener.Acceptor modify:
      Acceptor() throws IOException

      { m_serverSocket = new ServerSocket(m_port, 1, InetAddress.getByName(m_ip)); m_serverSocket.setSoTimeout(m_soTimeout); }

      for
      Acceptor() throws IOException

      { m_serverSocket = new ServerSocket(m_port, 1, m_ip == null ? null : InetAddress.getByName(m_ip)); m_serverSocket.setSoTimeout(m_soTimeout); }

      Attachments

        Activity

          People

            rickhall Richard S. Hall
            jogoussard Jacques-Olivier Goussard
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: