Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-13903

`coho prepare-platform-release-branch` removes `cordova-js/node_modules` which contains `grunt` that is required for it to run

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Duplicate
    • None
    • None
    • cordova-coho
    • None

    Description

      I am at the step in the platform release process where I should run `coho prepare-platform-release-branch` and it is failing.

      sujan@LenovoX1:/mnt/c/Projects/Cordova$ coho prepare-platform-release-branch --version 6.0.0 -r windows
      Running from /mnt/c/Projects/Cordova
      cordova-windows/ =============== Executing: git remote update origin
      cordova-windows/ =============== Executing: git branch -r --list origin/master
        origin/master
      cordova-windows/ =============== Already up-to-date: cordova-windows
      cordova-windows/ =============== Executing: git branch -r --list origin/6.0.x
      cordova-windows/ =============== Executing: git checkout 6.0.x
      Already on '6.0.x'
      cordova-js/ ==================== Executing: git stash save --all --quiet coho stash
      cordova-js/ ==================== Executing: git remote update origin
      cordova-js/ ==================== Executing: git branch -r --list origin/master
        origin/master
      cordova-js/ ==================== Already up-to-date: cordova-js
      cordova-js/ ==================== Executing: grunt compile:windows --platformVersion=6.0.0
      grunt-cli: The grunt command line interface (v1.2.0)
      
      Fatal error: Unable to find local grunt.
      
      If you're seeing this message, grunt hasn't been installed locally to
      your project. For more information about installing and configuring grunt,
      please see the Getting Started guide:
      
      http://gruntjs.com/getting-started
      (node:360) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 13): Error: grunt: Command failed with exit code 99
      (node:360) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
      

      Running the command fails.

      sujan@LenovoX1:/mnt/c/Projects/Cordova$ cd cordova-js
      sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-js$ npm install
      npm WARN deprecated coffee-script@1.12.7: CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
      npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
      npm WARN deprecated minimatch@0.4.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
      npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
      npm notice created a lockfile as package-lock.json. You should commit this file.
      added 479 packages in 196.049s
      

      So I switch over to install grunt via `npm install`. Then I run the failing command manually to test:

      sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-js$ grunt compile:windows --platformVersion=6.0.0
      Running "compile:windows" (compile) task
      generated cordova.windows.js @ 4450a4cea50616e080a82e8ede9e3d6a1fe3c3ec in 22ms
      
      Done.
      

      Works, as it should, so now back to where I was before and run again:

      sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-js$ cd ..
      sujan@LenovoX1:/mnt/c/Projects/Cordova$ coho prepare-platform-release-branch --version 6.0.0 -r windows
      Running from /mnt/c/Projects/Cordova
      cordova-windows/ =============== Executing: git remote update origin
      cordova-windows/ =============== Executing: git branch -r --list origin/master
        origin/master
      cordova-windows/ =============== Already up-to-date: cordova-windows
      cordova-windows/ =============== Executing: git branch -r --list origin/6.0.x
      cordova-windows/ =============== Executing: git checkout 6.0.x
      Already on '6.0.x'
      cordova-js/ ==================== Executing: git stash save --all --quiet coho stash
      cordova-js/ ==================== Executing: git remote update origin
      cordova-js/ ==================== Executing: git branch -r --list origin/master
        origin/master
      cordova-js/ ==================== Already up-to-date: cordova-js
      cordova-js/ ==================== Executing: grunt compile:windows --platformVersion=6.0.0
      grunt-cli: The grunt command line interface (v1.2.0)
      
      Fatal error: Unable to find local grunt.
      
      If you're seeing this message, grunt hasn't been installed locally to
      your project. For more information about installing and configuring grunt,
      please see the Getting Started guide:
      
      http://gruntjs.com/getting-started
      (node:521) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 13): Error: grunt: Command failed with exit code 99
      (node:521) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
      

      And again the same error. When I check back in `cordova-js` the `node_modules` folder is missing. What!?

      Just to check:

      sujan@LenovoX1:/mnt/c/Projects/Cordova$ coho repo-update -r js
      Running from /mnt/c/Projects/Cordova
      cordova-js/ ==================== Executing: git remote update origin
      cordova-js/ ==================== Executing: git branch -r --list origin/master
        origin/master
      cordova-js/ ==================== Already up-to-date: cordova-js
      sujan@LenovoX1:/mnt/c/Projects/Cordova$
      

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              Sujan12 Jan Piotrowski (janpio)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: