Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-9265

Add checksum to saved cache files

Agile BoardAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • 2.2.1, 3.0 beta 1
    • None
    • None

    Description

      Saved caches are not covered by a checksum. We should at least emit a checksum. My suggestion is a large checksum of the whole file (convenient offline validation), and then smaller per record checksums after each record is written (possibly a subset of the incrementally maintained larger checksum).

      I wouldn't go for anything fancy to try to recover from corruption since it is just a saved cache. If corruption is detected while reading I would just have it bail out. I would rather have less code to review and test in this instance.

      Attachments

        1. 0001-Add-checksum-to-saved-cache-files-CASSANDRA-9265.patch
          23 kB
          Daniel Chia
        2. 0002-trunk-CASSANDRA-9265.patch
          23 kB
          Daniel Chia
        3. 9265-2.2.txt
          3 kB
          Aleksey Yeschenko
        4. 9265-3.0.txt
          3 kB
          Aleksey Yeschenko

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            danchia Daniel Chia Assign to me
            aweisberg Ariel Weisberg
            Daniel Chia
            Ariel Weisberg
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment