[CASSANDRA-19632] wrap tracing logs in isTraceEnabled across the codebase - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Normal
Resolution: Fixed
Fix Version/s: 5.1
Component/s: Legacy/Core
Labels:
None

Change Category:
Code Clarity
Complexity:
Normal
Platform:

All
Impacts:

None
Source Control Link:

https://github.com/apache/cassandra/commit/8ba2f9e8c00cbb68cc1f30fc10de9212458c5756
Test and Documentation Plan:

Hide

ci

Show
ci

Description

Our usage of logger.isTraceEnabled across the codebase is inconsistent. This would also fix issues similar in e.g. CASSANDRA-19429 as rustyrazorblade suggested.

We should fix this at least in trunk and 5.0 (not critical though) and probably come up with a checkstyle rule to prevent not calling isTraceEnabled while logging with TRACE level.

Attachments

Issue Links

links to

GitHub Pull Request #3329

Activity

People

Assignee:: Stefan Miklosovic

Reporter:: Stefan Miklosovic

Authors:: Stefan Miklosovic

Reviewers:: Brandon Williams

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 10/May/24 10:22

Updated:: 30/May/24 14:49

Resolved:: 30/May/24 14:49

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

40m