Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-19015

Nodetool 'tablestats' formatting uses inconsistent significant digits

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Low
    • Resolution: Fixed
    • 5.1
    • Tool/nodetool
    • None
    • Quality Assurance
    • Low Hanging Fruit
    • All
    • None
    • Hide

      nodetool tablestats returns latencies and ratios in a more consistent format:

      Keyspace: system
              Read Count: 18
              Read Latency: 5.084 ms
              Write Count: 22
              Write Latency: 0.566 ms
              Pending Flushes: 0
                      Table: IndexInfo
      ...
                      SSTable Compression Ratio: 1.146
      ...
                      Local read count: 1
                      Local read latency: 14.237 ms
                      Local write count: 1
                      Local write latency: 0.770 ms
                      Local read/write ratio: 1.000
      ...
                      Bloom filter false ratio: 0.000
      ...
                      Average live cells per slice (last five minutes): 61.43
                      Maximum live cells per slice (last five minutes): 72
                      Average tombstones per slice (last five minutes): 1.00
                      Maximum tombstones per slice (last five minutes): 1
                      Droppable tombstone ratio: 0.000

      Tests:

      ant testsome -Dtest.name=org.apache.cassandra.utils.FBUtilitiesTest

      CASSANDRA-19015-3.txt

      Show
      nodetool tablestats returns latencies and ratios in a more consistent format: Keyspace: system         Read Count: 18         Read Latency: 5.084 ms         Write Count: 22         Write Latency: 0.566 ms         Pending Flushes: 0                 Table: IndexInfo ...                 SSTable Compression Ratio: 1.146 ...                 Local read count: 1                 Local read latency: 14.237 ms                 Local write count: 1                 Local write latency: 0.770 ms                 Local read/write ratio: 1.000 ...                 Bloom filter false ratio: 0.000 ...                 Average live cells per slice (last five minutes): 61.43                 Maximum live cells per slice (last five minutes): 72                 Average tombstones per slice (last five minutes): 1.00                 Maximum tombstones per slice (last five minutes): 1                 Droppable tombstone ratio: 0.000 Tests: ant testsome -Dtest.name=org.apache.cassandra.utils.FBUtilitiesTest CASSANDRA-19015-3.txt

    Description

      Nodetool reports milliseconds (ms) with anywhere from 3 to 15 significant digits.  Ratios use five or sixteen decimal places.  Averages use 1 or 13 decimal places.

      • milliseconds should use 3 decimal places 
      • ratios should use 3 decimal places (tenths of a percent)
      • averages should use 1 or 2

      For readability, it would be helpful if large integers had comma separators.  I.e., space used: as 1,463,210,998,523 and/or in GiB/MiB/KiB.  It's unclear if the exact disk size is somehow useful, as it may change minute-by-minute, if not, rounding would be best, or displaying both   Space used (live): 1,463,210,998,523 (1,463GiB)

      Total number of tables: 83
      ----------------
      Keyspace : X
          Read Count: 1007337271
          Read Latency: 8.485891803649942 ms
          Write Count: 67550181
          Write Latency: 0.02556443163342523 ms
          Pending Flushes: 0
              Table: Y
              SSTable count: 7183
              Old SSTable count: 0
              SSTables in each level: [0, 9, 92, 754, 6328, 0, 0, 0, 0]
              Space used (live): 1463210998523
              Space used (total): 1463210998523
              Space used by snapshots (total): 0
              Off heap memory used (total): 607419608
              SSTable Compression Ratio: 0.3146620992793412
              Number of partitions (estimate): 24784137
              Memtable cell count: 106067
              Memtable data size: 248539982
              Memtable off heap memory used: 0
              Memtable switch count: 256
              Local read count: 865440924
              Local read latency: 6.857 ms
              Local write count: 13881409
              Local write latency: 0.037 ms
              Pending flushes: 0
              Percent repaired: 0.0
              Bytes repaired: 0.000KiB
              Bytes unrepaired: 4315.386GiB
              Bytes pending repair: 0.000KiB
              Bloom filter false positives: 11027855
              Bloom filter false ratio: 0.01099
              Bloom filter space used: 33590024
              Bloom filter off heap memory used: 33532560
              Index summary off heap memory used: 8174024
              Compression metadata off heap memory used: 565713024
              Compacted partition minimum bytes: 36
              Compacted partition maximum bytes: 17797419593
              Compacted partition mean bytes: 189740
              Average live cells per slice (last five minutes): 1443.2146104466253
              Maximum live cells per slice (last five minutes): 105778
              Average tombstones per slice (last five minutes): 1.0
              Maximum tombstones per slice (last five minutes): 1
              Dropped Mutations: 0
              Droppable tombstone ratio: 0.00000

      Attachments

        1. CASSANDRA-19015.txt
          4 kB
          Leo Toff
        2. CASSANDRA-19015-1.txt
          8 kB
          Leo Toff
        3. CASSANDRA-19015-2.txt
          10 kB
          Leo Toff
        4. CASSANDRA-19015-3.txt
          10 kB
          Leo Toff
        5. image-2023-11-27-13-36-39-282.png
          166 kB
          Stefan Miklosovic
        6. image-2023-11-27-13-49-14-247.png
          165 kB
          Stefan Miklosovic

        Issue Links

          Activity

            People

              zaaath Leo Toff
              bschoeni Brad Schoening
              Leo Toff
              Brandon Williams, Stefan Miklosovic
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h
                  2h