Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-18627

Tidy up vestigial code left over after CASSANDRA-17931

Agile BoardAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsAdd voteVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Degradation
    • Normal
    • Low Hanging Fruit
    • User Report
    • All
    • None
    • Hide

      No new testing; confirm existing tests pass.

      Show
      No new testing; confirm existing tests pass.

    Description

      In CASSANDRA-17931, some code was left over (additionalBytes, additionalSSTables) inside the PendingRepairManager which, while not explicitly hurting anything, provides for some confusion around when we do or don't take additional values into account when adjusting for pending operations when deciding what to do with upcoming repairs etc.

       

      We should tidy that up and consider making the role of those methods / their structure more clear between the {

      {PendingRepairManager]}

      hierarchy and the AbstractCompactionStrategy hierarchy to prevent further confusion.

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jmckenzie Josh McKenzie Assign to me
            jmckenzie Josh McKenzie
            Josh McKenzie
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Slack

                Issue deployment