[CASSANDRA-18212] Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Normal
Resolution: Fixed
Fix Version/s: 5.0-alpha1, 5.0
Component/s: Legacy/Local Write-Read Paths
Labels:
None

Change Category:
Performance
Complexity:
Low Hanging Fruit
Platform:

All
Impacts:

None
Source Control Link:

https://github.com/apache/cassandra/commit/35f8da66f9b05d18b4177f8d2e1b86c772ad2221
Test and Documentation Plan:

Hide

Performance testing and circle ci testing done

Show
Performance testing and circle ci testing done

Description

Currently, org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% of memory allocations in production. No changes have been made to reduce this but there is discussion related to the issue in ~~CASSANDRA-13741~~. Attached below are the performance result for disk based queries and mostly memory based queries.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending

allocations-after.html
08/Feb/23 20:18
197 kB
Natnael Adere
allocations-before.html
08/Feb/23 20:18
216 kB
Natnael Adere
DiskBased.png
31/Jan/23 21:48
487 kB
Natnael Adere

Issue Links

links to

GitHub Pull Request #2122

Activity

People

Assignee:: Natnael Adere

Reporter:: Natnael Adere

Authors:: Natnael Adere

Reviewers:: Benedict Elliott Smith, David Capwell

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 31/Jan/23 21:06

Updated:: 12/Sep/23 13:02

Resolved:: 06/Mar/23 20:05

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 50m