[CASSANDRA-17731] Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for in-JVM dtests - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Normal
Resolution: Fixed
Fix Version/s: 4.0.6, 4.1-beta1, 5.0-alpha1, 5.0
Component/s: Test/dtest/java
Labels:
None

Bug Category:
Correctness - Test Failure
Severity:
Low
Complexity:
Low Hanging Fruit
Discovered By:
Code Inspection
Platform:

All
Impacts:

None
Since Version:

4.0
Source Control Link:

https://github.com/apache/cassandra/commit/d51f90201b2d127166612384a75b4a49da9776d1
Test and Documentation Plan:

Hide

n/a (the patch itself is test fixes)

Show
n/a (the patch itself is test fixes)

Description

There appear to be two problems w/ the way we shut down ScheduledExecutors in Instance in 4.0+:

1.) We do it twice, Ince as part of a larger batch of shutdown activity, and then again in its own parallelRun() block.
2.) It happens before MessagingService shuts down, but some messaging-related threads (see StreamSession#closeSession()) can submit tasks to nonPeriodicTasks.

We should do it once, and do it after the MessagingService has properly shut down.

Attachments

Issue Links

fixes

CASSANDRA-17139 readWriteDuringBootstrapTest - org.apache.cassandra.distributed.test.ring.BootstrapTest

Resolved

is related to

CASSANDRA-16778 Jvm-dtest race on closing and log messages

Open

relates to

CASSANDRA-17139 readWriteDuringBootstrapTest - org.apache.cassandra.distributed.test.ring.BootstrapTest

Resolved

Activity

People

Assignee:: Caleb Rackliffe

Reporter:: Caleb Rackliffe

Authors:: Caleb Rackliffe

Reviewers:: David Capwell

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 05/Jul/22 20:01

Updated:: 12/Sep/23 13:02

Resolved:: 14/Jul/22 16:56

Time Tracking

Estimated:

Not Specified

Remaining:

Logged: