[CASSANDRA-17650] Check startup and setter validations for batch_size_fail_threshold - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Low
Resolution: Fixed
Fix Version/s: 4.1-beta1, 4.1, 5.0-alpha1, 5.0
Component/s: Local/Config
Labels:
None

Complexity:
Low Hanging Fruit
Platform:

All
Impacts:

None
Since Version:

4.1-alpha1
Source Control Link:

https://github.com/apache/cassandra/commit/07e5876c43998fe7384df115c65749d668183130
Test and Documentation Plan:

Hide

The current unit tests pass plus a new one was added to prevent us from future regressions

Show
The current unit tests pass plus a new one was added to prevent us from future regressions

Description

During manual inspection it was noticed that batch_size_warn_threshold goes through checkValidForByteConversion, but this is not the case for batch_size_fail_threshold.

This ticket is opened to check whether this is a bug or not.

If it is confirmed it is a bug it needs to be fixed and the ticket can be changed to type bug. It seems that this validation was added as part of ~~CASSANDRA-15470~~ to 4.0+. Maybe we also need it in 3.0 and 3.11?

CC adelapena

Attachments

Issue Links

is related to

CASSANDRA-17716 Fix widening - mebibytes to bytes in IntMebibytesBound

Resolved

links to

PR trunk

Activity

People

Assignee:: Akin Tekeoglu

Reporter:: Ekaterina Dimitrova

Authors:: Akin Tekeoglu

Reviewers:: Andres de la Peña, Ekaterina Dimitrova

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 20/May/22 21:18

Updated:: 12/Sep/23 13:02

Resolved:: 28/Jun/22 22:28

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 50m