[CASSANDRA-16028] cqlsh tests broken in Python 3.7+ - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Normal
Resolution: Fixed
Fix Version/s: 4.0-beta2, 4.0
Component/s: Tool/cqlsh
Labels:
None

Bug Category:
Code
Severity:
Low
Complexity:
Low Hanging Fruit
Discovered By:
Unit Test
Platform:

All
Impacts:

None
Since Version:

2.1.21
Source Control Link:

https://github.com/apache/cassandra/commit/f93c5631636020cd3fa1f39d0ac92959102bd5eb
Test and Documentation Plan:
Hide

repro/validation:

activate python 3.7+

cd pylib/cqlshlib; nosetests
<confirm attribute error>

apply patch

run tests again, expecting success

activate python 3.6 and/or 2.7 and verify

No docs required.
Show
repro/validation: activate python 3.7+ cd pylib/cqlshlib; nosetests <confirm attribute error> apply patch run tests again, expecting success activate python 3.6 and/or 2.7 and verify No docs required.

Description

// cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
    if not isinstance(until, re._pattern_type):
AttributeError: module 're' has no attribute '_pattern_type'

An internal module attribute was changed/removed from Python 3.7 on.

https://github.com/python/cpython/pull/1646/files#diff-daea55f2fca784d9a64ca8f190403904R267-L272

This breakage did not manifest in CI because the test use the Jenkins host system Python, which is 3.6.

I have a trivial patch I'll add shortly.

Attachments

Activity

People

Assignee:: Adam Holmberg

Reporter:: Adam Holmberg

Authors:: Adam Holmberg

Reviewers:: Brandon Williams

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 05/Aug/20 18:02

Updated:: 03/Jan/21 17:03

Resolved:: 05/Aug/20 18:48

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

10m