Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-15450

in-jvm dtest cluster uncaughtExceptions propagation of exception goes to the wrong instance, it uses cluster generation when it should be using the instance id

    XMLWordPrintableJSON

Details

    • Code - Bug - Unclear Impact
    • Normal
    • Low Hanging Fruit
    • Unit Test
    • All
    • None
    • 4.0
    • Hide

      Patch located here: https://github.com/apache/cassandra/pull/397

      Replicated the issue in IntelliJ by selecting 

      GossipSettlesTest

      and 

      FailingRepairTest

      and calling run. Before this patch, FailingRepairTest hangs until timeout, it never sees the jvm kill attempt (went to the wrong host); after this patch the correct host gets killed

      Show
      Patch located here: https://github.com/apache/cassandra/pull/397 Replicated the issue in IntelliJ by selecting GossipSettlesTest and FailingRepairTest and calling run. Before this patch, FailingRepairTest hangs until timeout, it never sees the jvm kill attempt (went to the wrong host); after this patch the correct host gets killed

    Description

      In AbstractCluster.uncaughtExceptions, we attempt to get the instance from the class loader and used the “generation”. This value is actually the cluster id, so causes tests to fail when multiple tests share the same JVM; it should be using the “id” field which represents the instance id relative to the cluster.

      Attachments

        Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. CASSANDRA-15456 Backport CASSANDRA-15332 dtest changes to 3.x

          • Normal -
          • Resolved
          links to

          Web Link GitHub Pull Request #397

          Activity

            People

              dcapwell David Capwell
              dcapwell David Capwell
              David Capwell
              Alex Petrov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m