Details

    • Sub-task
    • Status: Resolved
    • P2
    • Resolution: Fixed
    • Not applicable
    • Not applicable
    • sdk-go
    • None

    Description

      Catch all task for any data channel stuckness issues, in particular if any happen on errors. Re-open this issue if a new one is found.

      The last known one I have is a race condition on DataChannel.readErr 

      Close off a race condition where a closing DataChannel might have new readers created for it while it is failing, causing stuckness in the bundles.

      In particular, the c.readErr must be interacted while c.mu is held.
      Otherwise something like the following happens.
      Given a channel C, and goroutines G1,G2.

      1. G1 A request for a new reader on C arrives, checks C.readErr finds it null.
      2. G2 An error occurs on reading. The lock is acquired, and C.readErr is set. Readers are closed. The channel is officially closed with A.forceRecreate, removing it from the DataManager cache.
      3. G1 calls A.makeReader, and creates a new reader there.

      There could be an arbitrary number of G1s.

       

      Attachments

        Issue Links

          Activity

            People

              lostluck Robert Burke
              lostluck Robert Burke
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m