Details

    Description

      I think we do not need null check here:

      https://github.com/apache/beam/blob/master/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/FnApiControlClient.java#L151

      Because before the the `onNext` call, the `Future` already put into the queue in `handle` method.

       

      I found the test as follows:

       @Test
       public void testUnknownResponseIgnored() throws Exception

      I do not know why we need test this case? I think it would be better if we throw the Exception for an UnknownResponse, otherwise, this may hidden a potential bug. 

      Please correct me if there anything I misunderstand @kennknowles

       

      Attachments

        Issue Links

          Activity

            People

              sunjincheng121 sunjincheng
              sunjincheng121 sunjincheng
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h 20m
                  2h 20m