Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-8473

Python typehints: spurious warnings for Generator None args

Details

    • Bug
    • Status: Resolved
    • P3
    • Resolution: Fixed
    • None
    • Missing
    • sdk-py-core

    Description

      GeneratorHint outputs warnings if the 2 last args of typing.Generator are not None.
      1. Compare to type(None) instead of None, since that's what the code converts those to. (assert on logging output)
      2. (fixed) Bug: comparing send_type in both cases.
      https://github.com/apache/beam/blob/06fa1cc2a92a6f4f0e05f162ee2eb78b072920d9/sdks/python/apache_beam/typehints/typehints.py#L1088-L1091

      Attachments

        Activity

          People

            Unassigned Unassigned
            udim Udi Meiri
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2.5h
                2.5h