Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-6545

NPE when decoding null base 64 strings

Details

    • Bug
    • Status: Resolved
    • P2
    • Resolution: Fixed
    • 2.9.0
    • 2.10.0
    • runner-dataflow
    • None

    Description

      **ByteArrayShufflePosition.fromBase64 is marked with a @Nullable argument, however it does not properly handle null inputs resulting in NPE.

      This seems like an unintended change we picked up from the dependency: google-http-java-client/ switched from apache commons to guava (https://github.com/googleapis/google-http-java-client/commit/990c534f0e5103a142b0639c12c90cb990a00cfd#diff-97264fba16d690a26d63fbbc992af937) 

       

      and decodeBase64 behaves differently in both cases. Former can handle null by returning null, latter will throw NPE.

       

      Attachments

        Issue Links

          Activity

            People

              kenn Kenneth Knowles
              altay Ahmet Altay
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m