Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-14239

Changing the output timestamp of a timer does not clear the previously set timer

Details

    • Bug
    • Status: Open
    • P1
    • Resolution: Unresolved
    • 2.37.0
    • None
    • runner-dataflow
    • None

    Description

      While looking into an unrelated bug with GroupIntoBatches, I noticed that it seems like changing the output timestamp of a timer does not clear the existing timer, and instead creates a new one.  

      This kind of makes sense looking at the implementation of timers in Dataflow, the output timestamp is encoded into the timer ID, but this is not reflected in the timerStillPresent map in WindmillTimerInternals.  It seems like it should be, and the previous timer should be deleted.

      Attachments

        1. image-2022-04-04-09-57-29-583.png
          95 kB
          Steve Niemitz

        Activity

          People

            reuvenlax Reuven Lax
            SteveNiemitz Steve Niemitz
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated: