Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-14179

MonitoringInfoMetricName null value guard uncovering additional issues

Details

    Description

      Additional integration testing (//cloud/dataflow/testing/integration/sdk:V1ReadIT_testE2EV1Read) caught that https://github.com/apache/beam/pull/17094 causes a regression:

      The test failed with:

      Caused by: java.lang.NullPointerException: null value in entry: DATASTORE_NAMESPACE=null
      	at org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.CollectPreconditions.checkEntryNotNull(CollectPreconditions.java:32)
      	at org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.RegularImmutableMap.fromEntryArray(RegularImmutableMap.java:100)
      	at org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.RegularImmutableMap.fromEntries(RegularImmutableMap.java:74)
      	at org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableMap.copyOf(ImmutableMap.java:464)
      	at org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableMap.copyOf(ImmutableMap.java:437)
      	at org.apache.beam.runners.core.metrics.MonitoringInfoMetricName.<init>(MonitoringInfoMetricName.java:46)
      	at org.apache.beam.runners.core.metrics.MonitoringInfoMetricName.named(MonitoringInfoMetricName.java:93)
      	at org.apache.beam.runners.core.metrics.ServiceCallMetric.call(ServiceCallMetric.java:82)
      	at org.apache.beam.sdk.io.gcp.datastore.DatastoreV1$Read$ReadFn.runQueryWithRetries(DatastoreV1.java:927)
      	at org.apache.beam.sdk.io.gcp.datastore.DatastoreV1$Read$ReadFn.processElement(DatastoreV1.java:965)
      

      Attachments

        Activity

          People

            danoliveira Daniel Oliveira
            lcwik Luke Cwik
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h
                1h