Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-13824

Migrate SnsIO.write to async implementation

Details

    • Improvement
    • Status: Open
    • P2
    • Resolution: Unresolved
    • None
    • None
    • io-java-aws

    Description

      In  BEAM-13203 SnsIO.writeAsync was deprecated to address the risk of data loss in that transform. Unfortunately, it has considerable issues in design and implementation with respect to the beam programming model as well as general async programming:

      • Output for a bundle may be emitted even after the bundle is finished (lack of join / waiting for pending futures), additionally output is emitted from multiple threads risking concurrent modification issues on underlying data structures.
      • Exceptions disappear into the void (respective tests are implemented incorrectly as they don't throw asynchronously and could make one think this works).
      • Parallelism is unlimited causing the writer to instantly accumulate everything into memory.

      With BEAM-13563 it will be possible to change SnsIO.write into a more performant async implementation without any breaking changes to the public user facing API making SnsIO.writeAsync obsolete.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              mosche Moritz Mack
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: