Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-13460

IsmSideInputReaderTest.verifyMap does not make some contains assertions

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • P3
    • Resolution: Unresolved
    • None
    • None
    • runner-dataflow
    • None

    Description

      See for example https://github.com/apache/beam/blob/a8162f2fe92fbc982f72289dfca7b56f1fdb0762/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/IsmSideInputReaderTest.java#L1579

      There are three such "assertions" in verifyMap. When these are made into actual assertions (e.g. using assertTrue), the test fails.

      Attachments

        Issue Links

          Discovered while testing

          Task - A task that needs to be done. BEAM-13271 error-prone UnusedVariable check raises false positives for StateId and TimerId usages

          • P3 - Non-urgent bugs, features, and improvements
          • Open

          Activity

            People

              Unassigned Unassigned
              bhulette Brian Hulette
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: